Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade lerna to 6.0.0 + alpha fixes #865

Merged
merged 3 commits into from
Nov 14, 2022
Merged

Upgrade lerna to 6.0.0 + alpha fixes #865

merged 3 commits into from
Nov 14, 2022

Conversation

dlasky
Copy link
Contributor

@dlasky dlasky commented Nov 10, 2022

Some long overdue quality of life fixes for actions repo

Bumps lerna to the latest version, and changes the alpha command so that it now uses a branch specific pre-id which should prevent 'stepping' on other branches alphas when publishing test versions.

Testing

Tested by running publish command locally, as well as creating some fake commits to push and exercising the new alpha command.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [Segmenters] Tested in the staging environment

@NolanChan
Copy link
Contributor

NolanChan commented Nov 10, 2022

@dlasky am I doing this wrong? I installed the new packages. Whether or not I add a new commit, yarn alpha isn't pushing anything up

(stage-write/stage:us-west-2:centrifuge-destinations) $ yarn alpha
yarn run v1.22.19
$ lerna publish --canary --preid $(git branch --show-current)
lerna notice cli v4.0.0
lerna info versioning independent
lerna info canary enabled
lerna WARN Yarn's registry proxy is broken, replacing with public npm registry
lerna WARN If you don't have an npm token, you should exit and run `npm login`
lerna info Looking for changed packages since cd8e3d09^..cd8e3d09
lerna success No changed packages to publish
✨  Done in 1.08s.

@dlasky
Copy link
Contributor Author

dlasky commented Nov 10, 2022

did you make a meaningful change in the commit? if the resulting build has no deltas it wont push anything.

@NolanChan
Copy link
Contributor

ah interesting! I just touch'd a random file so nothing showed up, that's cool that alpha will detect changed and not changed packages!

(stage-write/stage:us-west-2:centrifuge-destinations) $ yarn alpha
yarn run v1.22.19
$ lerna publish --canary --preid $(git branch --show-current)
lerna notice cli v6.0.3
lerna info versioning independent
lerna info canary enabled
lerna WARN Yarn's registry proxy is broken, replacing with public npm registry
lerna WARN If you don't have an npm token, you should exit and run `npm login`
lerna info Looking for changed packages since 3e77e363^..3e77e363

Found 1 package to publish:
 - @segment/action-destinations => 3.115.1-staging.6+3e77e363

? Are you sure you want to publish these packages? No
✨  Done in 13.49s.

@NolanChan NolanChan self-requested a review November 10, 2022 22:19
Copy link
Contributor

@NolanChan NolanChan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally!

@dlasky dlasky merged commit aa477a4 into main Nov 14, 2022
@dlasky dlasky deleted the upgrade-lerna branch November 14, 2022 18:10
rhall-twilio pushed a commit that referenced this pull request Nov 14, 2022
* upgrade lerna to 6

* alpha two

* promote to alpha
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants