[STRATCONN-3468] | Introduce 'Amazon AMC' Audience Destination #2036

Innovative-GauravKochar · 2024-05-14T12:40:01Z

Jira Ticket :- https://segment.atlassian.net/jira/software/c/projects/STRATCONN/boards/310?assignee=63617339fc0cc7a600b03c6b&selectedIssue=STRATCONN-3746
This Pr is to add a new action destination 'Amazon Ads' to sync audience in Amazon.
Please refer to this to get to know more about this new action destination.

Related PRs
Integrations PR
Audience Dest service PR

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

Added unit tests for new functionality
Tested end-to-end using the local server
[Segmenters] Tested in the staging environment

packages/destination-actions/src/destinations/amazon-ads/__tests__/index.test.ts

packages/destination-actions/src/destinations/amazon-ads/syncAudiences/index.ts

varadarajan-tw

Nice work! Left few questions and suggestions.

packages/destination-actions/src/destinations/amazon-ads/syncAudiences/index.ts

packages/destination-actions/src/destinations/amazon-ads/index.ts

packages/destination-actions/src/destinations/amazon-ads/syncAudiences/index.ts

packages/destination-actions/src/destinations/index.ts

packages/destination-actions/src/destinations/amazon-amc/types.ts

joe-ayoub-segment · 2024-05-28T10:27:03Z

packages/destination-actions/src/destinations/amazon-amc/index.ts

+    currency: {
+      label: 'Currency',
+      type: 'string',
+      description: `The price paid. Base units depend on the currency. As an example, USD should be reported as Dollars.Cents, whereas JPY should be reported as a whole number of Yen. All provided values will be rounded to two digits with toFixed(2).Refer [Aamzon Ads Documentation](https://advertising.amazon.com/API/docs/en-us/amc-advertiser-audience#tag/Audience-Metadata/operation/CreateAudienceMetadataV2) to view supported Currency`


Could this not simply be a list of choices?
It would reduce the need to write code to validate, and it would make it easier for the customer to know what values to provide.

export const CURRENCY = ['USD', 'CAD', 'JPY', 'GBP', 'EUR', 'SAR', 'AUD', 'AED', 'CNY', 'MXN', 'INR', 'SEK', 'TRY']

joe-ayoub-segment · 2024-05-28T10:27:30Z

packages/destination-actions/src/destinations/amazon-amc/index.ts

+    currency: {
+      label: 'Currency',
+      type: 'string',
+      description: `The price paid. Base units depend on the currency. As an example, USD should be reported as Dollars.Cents, whereas JPY should be reported as a whole number of Yen. All provided values will be rounded to two digits with toFixed(2).Refer [Aamzon Ads Documentation](https://advertising.amazon.com/API/docs/en-us/amc-advertiser-audience#tag/Audience-Metadata/operation/CreateAudienceMetadataV2) to view supported Currency`


Should this description be more relevant to the cpmCents field rather than the currency field?

joe-ayoub-segment · 2024-05-28T10:30:37Z

packages/destination-actions/src/destinations/amazon-amc/syncAudiencesToDSP/index.ts

+const action: ActionDefinition<Settings, Payload> = {
+  title: 'Sync Audiences to DSP',
+  description: 'Sync audiences from Segment to Amazon Ads Audience.',
+  defaultSubscription: 'event = "Audience Entered" or event = "Audience Exited"',


Why isn't the subscription simply type="track" or type="identify" ?
We can't rely on the name of event as a subscription value. I know this has been done in previous Audience Destinations but it is wrong.

joe-ayoub-segment · 2024-05-28T12:07:30Z

Hi @Innovative-GauravKochar PR deployed. Please check it all looks good!

commit c37259c Author: Harsh Joshi <[email protected]> Date: Wed Jun 5 16:05:46 2024 +0530 Update test cases commit 6ab6d57 Author: Harsh Joshi <[email protected]> Date: Tue Jun 4 15:15:20 2024 +0530 Add profile properties in Add profilr to ost event commit 524fc6c Author: Varadarajan V <[email protected]> Date: Wed May 29 17:41:51 2024 +0530 Remove build-experience-team from pr labeler as internal team (#2060) commit 72adc64 Author: Joe Ayoub <[email protected]> Date: Tue May 28 11:04:54 2024 +0100 Publish - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] commit e4bb620 Author: Prayansh Srivastava <[email protected]> Date: Tue May 28 02:25:29 2024 -0700 add new excludeWhenNull directive and update tests (#2040) * add new excludeWhenNull directive and update tests * add readme docs * fix replace test case commit e7b424a Author: harsh-joshi99 <[email protected]> Date: Tue May 28 14:53:39 2024 +0530 Add override_list_id mapping in upsert Profile (#2046) * Add override_list_id mapping in upsert Profile, add function to group profiles based on list ID * fix payload * Fix payload condition * Refactor profile filter commit 6170334 Author: Joe Ayoub <[email protected]> Date: Tue May 28 10:18:32 2024 +0100 updating field description and updating generated types commit 1107970 Author: Alice Mackel <[email protected]> Date: Tue May 28 05:07:52 2024 -0400 Change StackAdapt destination name (#2055) commit 76c733d Author: Leonel Sanches <[email protected]> Date: Tue May 28 02:07:21 2024 -0700 Preventing double-hashing for TikTok Offline Conversions. (#2034) commit a621179 Author: Nuno Sousa <[email protected]> Date: Tue May 28 10:07:09 2024 +0100 Fix customer.io timestamp issue (#2054) commit 1c71987 Author: Leonel Sanches <[email protected]> Date: Tue May 28 02:06:52 2024 -0700 Preventing double-hashing for TikTok Conversions. (#2033) commit 4b27451 Author: Nick Campbell <[email protected]> Date: Tue May 28 10:06:28 2024 +0100 Implement batch support for Attio Actions (#2057) * Implement batch APIs for Attio * Make received_at parameter optional and gracefully handle it * Make "enable_batching" parameter viewable, optional, default false There are tradeoffs associated with Segment event batching - there is no realtime feedback if the request was invalid, for example - so we should make it opt-in and controllable by the user. commit 0fd6c22 Author: Innovative-GauravKochar <[email protected]> Date: Tue May 28 14:33:36 2024 +0530 [STRATCONN-3468] | Introduce 'Amazon AMC' Audience Destination (#2036) * Updated the code for amazon ads syncaudience action * Fix the build failing * Updated the getAudience and createAudience * Code to update the value to hashed * Added the advertiserId field in audienceSetting * Added check for advertiserid * Fixing External Id issue , replace with quoted string * Resolve Conflicts * Resolve Conflicts * Resolve Conflicts * Worked on unit test case for createAUdience and syncAudience * Code cleaning * removed stats * Updated Snapshots * added headers in refresh Access token * Fix refresh access token API * Worked on handling cpmCents and ttl * Fixed Pr Comments * Rename destination slug nad action name * removed amazon-ads as we are changing action destination slug * Validate Schema in createAudience * registered amazon-amc and updated destination id * will handle this in seperate PR --------- Co-authored-by: Harsh Vardhan <[email protected]> Co-authored-by: Gaurav Kochar <[email protected]> commit 2fc41f9 Author: Varadarajan V <[email protected]> Date: Fri May 24 11:49:25 2024 +0530 [snyk] bump jscodeshift from 0.13.0 to 0.14.0 (#2056) commit e790949 Author: alfrimpong <[email protected]> Date: Wed May 22 00:59:22 2024 -0500 feat: add script for action-cli shared (#2050)

commit f93c309 Author: Harsh Joshi <[email protected]> Date: Mon Jun 10 11:37:25 2024 +0530 Update snapshot commit e939c24 Author: Harsh Joshi <[email protected]> Date: Fri Jun 7 17:04:57 2024 +0530 Update profile identifiers for track and order completed events. commit 77b91d0 Author: Gaurav Kochar <[email protected]> Date: Thu Jun 6 15:17:54 2024 +0530 Publish - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] commit 127c4c2 Author: Innovative-GauravKochar <[email protected]> Date: Thu Jun 6 15:10:11 2024 +0530 Worked on fixing the refresh access token issue and made currency dropdown (#2079) Co-authored-by: Gaurav Kochar <[email protected]> commit 6dfaf37 Author: Alice Mackel <[email protected]> Date: Wed Jun 5 10:42:27 2024 -0400 Change name of browser destination (#2058) commit 3510923 Author: Joe Ayoub <[email protected]> Date: Wed Jun 5 12:46:59 2024 +0100 Publish - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] commit fec0383 Author: alfrimpong <[email protected]> Date: Wed Jun 5 05:30:50 2024 -0500 Fcm payload update (#2073) * fix fcm payload * fix: removed FCM overrides * chore: rm log commit 9515a35 Author: konoufo <[email protected]> Date: Tue Jun 4 17:39:16 2024 -0400 [DC-789] adds subscription sync modes support in destination-kit (#2065) * adds subscription sync modes support in destination-kit * renames SyncModes type * remove test.only * adds syncMode support in performBatch handler + remove... ... internal field from payload --------- Co-authored-by: Mohamed K. Coulibali <[email protected]> commit f83f691 Author: Joe Ayoub <[email protected]> Date: Tue Jun 4 13:53:06 2024 +0100 Publish - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] commit c9d30b4 Author: hanoak20 <[email protected]> Date: Tue Jun 4 18:12:06 2024 +0530 Contentstack's destination enhancement. (#2062) * feat: added Contentstack's destination-action. * chore: segregated the types of destination, and other improvements. * fix: Action schema changed to oauth-managed. * refactor: used 'extendRequest' function to add headers automatically. * refactor: removed yarn PackageManager config. * refactor: simplified the perform's data and its usage. * chore: personalize urls are now configurable. commit e99e29f Author: Matthew Saunders <[email protected]> Date: Tue Jun 4 08:40:32 2024 -0400 Update MC contacts upsert to handle multiple identifiers (#2032) * Update MC contacts upsert to handle multiple identifiers * Update defaults for phone_number_id, anonymous_id * Update default for anonymous_id * Change anonymous_id to anonymousId commit 807258a Author: Innovative-GauravKochar <[email protected]> Date: Tue Jun 4 17:37:56 2024 +0530 [AMAZON-AMC] | Fixed "415 Unsupported Media Type" issue while doing testAuthentication. (#2069) * [AMAZON-AMC] |Fixed content-Type issue in testAuthentication * Added unit test cases for content-type --------- Co-authored-by: Gaurav Kochar <[email protected]> commit c149f44 Author: Leonel Sanches <[email protected]> Date: Tue Jun 4 05:02:58 2024 -0700 Google Ads Enhanced Conversions: preventing double hashing (#2053) * - Preventing already hashed information to be hashed again; - Better typing for all actions. * Unit tests. * Checking whether the phone is hashed also for `uploadClickConversion` action. commit 7f24d61 Author: maryamsharif <[email protected]> Date: Tue Jun 4 05:02:36 2024 -0700 Add dropdown to region setting (#2044) commit dbec70c Author: Thomas Gilbert <[email protected]> Date: Tue Jun 4 08:02:05 2024 -0400 Fix to show request headers in Action's Tester UI (#2067) * add test destination * add request body * convert req headers to js object * remove test dest * add filtering for sensitive headers commit 5887a12 Author: Arijit Ray <[email protected]> Date: Tue Jun 4 17:31:20 2024 +0530 [STRATCONN-3772] Add new operator "number_equals" for number (#2030) * Add == operator in destination subscription package * Update/add new unit tests for the operator * limit == to just numeric values * update test cases STRATCONN-3772 * Add operator == in the AST level * Modified = to only store strings * Modified = to only store strings: update test cases * add == operator for traits AND CONTEXT * Add stringify on fqlExpression * Change operator name to number_equals * Change operator name to number_equals * Change operator name to number_equals * Refactor branching statements on parse-fq.ts commit 524fc6c Author: Varadarajan V <[email protected]> Date: Wed May 29 17:41:51 2024 +0530 Remove build-experience-team from pr labeler as internal team (#2060) commit 72adc64 Author: Joe Ayoub <[email protected]> Date: Tue May 28 11:04:54 2024 +0100 Publish - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] commit e4bb620 Author: Prayansh Srivastava <[email protected]> Date: Tue May 28 02:25:29 2024 -0700 add new excludeWhenNull directive and update tests (#2040) * add new excludeWhenNull directive and update tests * add readme docs * fix replace test case commit e7b424a Author: harsh-joshi99 <[email protected]> Date: Tue May 28 14:53:39 2024 +0530 Add override_list_id mapping in upsert Profile (#2046) * Add override_list_id mapping in upsert Profile, add function to group profiles based on list ID * fix payload * Fix payload condition * Refactor profile filter commit 6170334 Author: Joe Ayoub <[email protected]> Date: Tue May 28 10:18:32 2024 +0100 updating field description and updating generated types commit 1107970 Author: Alice Mackel <[email protected]> Date: Tue May 28 05:07:52 2024 -0400 Change StackAdapt destination name (#2055) commit 76c733d Author: Leonel Sanches <[email protected]> Date: Tue May 28 02:07:21 2024 -0700 Preventing double-hashing for TikTok Offline Conversions. (#2034) commit a621179 Author: Nuno Sousa <[email protected]> Date: Tue May 28 10:07:09 2024 +0100 Fix customer.io timestamp issue (#2054) commit 1c71987 Author: Leonel Sanches <[email protected]> Date: Tue May 28 02:06:52 2024 -0700 Preventing double-hashing for TikTok Conversions. (#2033) commit 4b27451 Author: Nick Campbell <[email protected]> Date: Tue May 28 10:06:28 2024 +0100 Implement batch support for Attio Actions (#2057) * Implement batch APIs for Attio * Make received_at parameter optional and gracefully handle it * Make "enable_batching" parameter viewable, optional, default false There are tradeoffs associated with Segment event batching - there is no realtime feedback if the request was invalid, for example - so we should make it opt-in and controllable by the user. commit 0fd6c22 Author: Innovative-GauravKochar <[email protected]> Date: Tue May 28 14:33:36 2024 +0530 [STRATCONN-3468] | Introduce 'Amazon AMC' Audience Destination (#2036) * Updated the code for amazon ads syncaudience action * Fix the build failing * Updated the getAudience and createAudience * Code to update the value to hashed * Added the advertiserId field in audienceSetting * Added check for advertiserid * Fixing External Id issue , replace with quoted string * Resolve Conflicts * Resolve Conflicts * Resolve Conflicts * Worked on unit test case for createAUdience and syncAudience * Code cleaning * removed stats * Updated Snapshots * added headers in refresh Access token * Fix refresh access token API * Worked on handling cpmCents and ttl * Fixed Pr Comments * Rename destination slug nad action name * removed amazon-ads as we are changing action destination slug * Validate Schema in createAudience * registered amazon-amc and updated destination id * will handle this in seperate PR --------- Co-authored-by: Harsh Vardhan <[email protected]> Co-authored-by: Gaurav Kochar <[email protected]> commit 2fc41f9 Author: Varadarajan V <[email protected]> Date: Fri May 24 11:49:25 2024 +0530 [snyk] bump jscodeshift from 0.13.0 to 0.14.0 (#2056) commit e790949 Author: alfrimpong <[email protected]> Date: Wed May 22 00:59:22 2024 -0500 feat: add script for action-cli shared (#2050)

Harsh Vardhan and others added 15 commits May 13, 2024 17:13

Updated the code for amazon ads syncaudience action

64608a0

Fix the build failing

c1004b7

Updated the getAudience and createAudience

a5c8685

Code to update the value to hashed

52bb3d4

Added the advertiserId field in audienceSetting

1025c6c

Added check for advertiserid

eb14072

Fixing External Id issue , replace with quoted string

f58f93c

Resolve Conflicts

dbdd2fc

Resolve Conflicts

82ae741

Resolve Conflicts

5e962a0

Worked on unit test case for createAUdience and syncAudience

3f4dec1

Code cleaning

a2e5025

removed stats

3297c0c

Updated Snapshots

4ea2efa

added headers in refresh Access token

0478234

github-actions bot added deploy:push mode:cloud team:segment labels May 14, 2024

Innovative-GauravKochar requested review from sayan-das-in, harsh-joshi99, AnkitSegment and varadarajan-tw May 14, 2024 12:44

AnkitSegment reviewed May 16, 2024

View reviewed changes

packages/destination-actions/src/destinations/amazon-ads/__tests__/index.test.ts Outdated Show resolved Hide resolved

AnkitSegment reviewed May 16, 2024

View reviewed changes

packages/destination-actions/src/destinations/amazon-ads/__tests__/index.test.ts Outdated Show resolved Hide resolved

joe-ayoub-segment added the not-partner-eng-review (cloud) label May 16, 2024

Gaurav Kochar added 2 commits May 17, 2024 10:46

Fix refresh access token API

68ae452

Worked on handling cpmCents and ttl

dfcc45a

Innovative-GauravKochar marked this pull request as ready for review May 20, 2024 13:04

Innovative-GauravKochar requested a review from a team as a code owner May 20, 2024 13:04

Innovative-GauravKochar requested a review from a team May 20, 2024 13:04

Innovative-GauravKochar requested a review from smultani May 20, 2024 13:05

varadarajan-tw reviewed May 21, 2024

View reviewed changes

packages/destination-actions/src/destinations/amazon-ads/syncAudiences/index.ts Outdated Show resolved Hide resolved

varadarajan-tw reviewed May 21, 2024

View reviewed changes

Gaurav Kochar added 2 commits May 22, 2024 14:31

Fixed Pr Comments

8aebd0c

Rename destination slug nad action name

1e02799

github-actions bot added the deploy:registration label May 24, 2024

removed amazon-ads as we are changing action destination slug

8e181eb

varadarajan-tw previously approved these changes May 24, 2024

View reviewed changes

packages/destination-actions/src/destinations/index.ts Outdated Show resolved Hide resolved

packages/destination-actions/src/destinations/amazon-amc/types.ts Outdated Show resolved Hide resolved

Gaurav Kochar added 2 commits May 24, 2024 18:20

Validate Schema in createAudience

13981e8

registered amazon-amc and updated destination id

4a36a75

Innovative-GauravKochar dismissed varadarajan-tw’s stale review via 4a36a75 May 27, 2024 07:48

github-actions bot added the actions:core label May 27, 2024

Innovative-GauravKochar changed the title ~~[STRATCONN-3468] | Introduce 'Amazon Ads' Audience Destination~~ [STRATCONN-3468] | Introduce 'Amazon AMC' Audience Destination May 28, 2024

will handle this in seperate PR

b57bf2f

github-actions bot removed the actions:core label May 28, 2024

varadarajan-tw removed the deploy:registration label May 28, 2024

Innovative-GauravKochar added the Ready for Release label May 28, 2024

Innovative-GauravKochar requested a review from varadarajan-tw May 28, 2024 08:28

varadarajan-tw approved these changes May 28, 2024

View reviewed changes

joe-ayoub-segment merged commit 0fd6c22 into main May 28, 2024
11 checks passed

joe-ayoub-segment deleted the STRATCONN-3468 branch May 28, 2024 09:03

joe-ayoub-segment reviewed May 28, 2024

View reviewed changes

varadarajan-tw mentioned this pull request Jun 24, 2024

[Release Scripts] Fix changelog formatting and bump checkout/setup-node github action versions #2052

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[STRATCONN-3468] | Introduce 'Amazon AMC' Audience Destination #2036

[STRATCONN-3468] | Introduce 'Amazon AMC' Audience Destination #2036

Innovative-GauravKochar commented May 14, 2024 •

edited

Loading

varadarajan-tw left a comment

joe-ayoub-segment May 28, 2024

joe-ayoub-segment May 28, 2024

joe-ayoub-segment May 28, 2024

joe-ayoub-segment commented May 28, 2024

[STRATCONN-3468] | Introduce 'Amazon AMC' Audience Destination #2036

[STRATCONN-3468] | Introduce 'Amazon AMC' Audience Destination #2036

Conversation

Innovative-GauravKochar commented May 14, 2024 • edited Loading

Testing

varadarajan-tw left a comment

Choose a reason for hiding this comment

joe-ayoub-segment May 28, 2024

Choose a reason for hiding this comment

joe-ayoub-segment May 28, 2024

Choose a reason for hiding this comment

joe-ayoub-segment May 28, 2024

Choose a reason for hiding this comment

joe-ayoub-segment commented May 28, 2024

Innovative-GauravKochar commented May 14, 2024 •

edited

Loading