[STRATCONN-3725] - Fixes request-client tests by upgrading dependency #2004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varadarajan-tw
commented
Apr 22, 2024
| @@ -17081,7 +17097,7 @@ [email protected]: | |||
| resolved "https://registry.yarnpkg.com/workerpool/-/workerpool-6.2.1.tgz#46fc150c17d826b86a008e5a4508656777e9c343" | |||
| integrity sha512-ILEIE97kDZvF9Wb9f6h5aXK4swSlKGUcOEGiIYb2OOu/IrDU9iwj0fD//SsA6E5ibwJxpEvhullJY4Sl4GcpAw== | |||
|
|
|||
| "wrap-ansi-cjs@npm:wrap-ansi@^7.0.0", wrap-ansi@^7.0.0: | |||
There was a problem hiding this comment.
There were no dependencies removed. wrap-ansi@^7.0.0 just re-arranged and moved to a separate line below
varadarajan-tw
commented
Apr 22, 2024
| @@ -15516,7 +15525,7 @@ stringify-object@^3.3.0: | |||
| is-obj "^1.0.1" | |||
| is-regexp "^1.0.0" | |||
|
|
|||
| "strip-ansi-cjs@npm:strip-ansi@^6.0.1", strip-ansi@^6.0.1: | |||
| "strip-ansi-cjs@npm:strip-ansi@^6.0.1": | |||
There was a problem hiding this comment.
no dependencies removed. strip-ansi@^6.0.1 just re-arranged and moved to a separate line below
varadarajan-tw
commented
Apr 22, 2024
| @@ -15458,7 +15458,16 @@ string-length@^4.0.1: | |||
| char-regex "^1.0.2" | |||
| strip-ansi "^6.0.0" | |||
|
|
|||
| "string-width-cjs@npm:string-width@^4.2.0", "string-width@^1.0.2 || 2 || 3 || 4", string-width@^4.2.3: | |||
There was a problem hiding this comment.
"string-width@^1.0.2 || 2 || 3 || 4", string-width@^4.2.3:" was just re-arranged and moved to a separate line.
|
confirmed that |
joe-ayoub-segment
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create-request-client tests and request-client tests were failing on Mac machines because the pinned version
pemmodule doesn't support open ssl 3 and all our mac machines are using openssl3.More details on the investigation here.
The solution is to bump pem, an indirect dependency through
create-request-clientdependency from 1.14.4 to 1.14.8 (ref). This dependency is only used in tests and not in production package.Testing
** Before **
After