Kafka destination #1892
Merged
Kafka destination #1892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pooyaj
reviewed
Feb 26, 2024
| description: | ||
| 'The brokers for your Kafka instance, in the format of `host:port`. Accepts a comma delimited string.', | ||
| type: 'string', | ||
| required: true |
There was a problem hiding this comment.
alternatively, we can do multiple: true instead of asking user to comma separate the brokers
There was a problem hiding this comment.
Thanks for the review @pooyaj . I had to leave this as a single string as I believe that Destination level settings can only be simple types. The UI doesn't allow for arrays AFAIK. I hope I'm wrong!
joe-ayoub-segment
force-pushed
the
kafka
branch
from
79d86fa to
fe9a1a0
Compare
|
Thanks for the PR review @pooyaj . |
joe-ayoub-segment
approved these changes
Feb 27, 2024
|
PR deployed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a basic implementation of a Kafka Destination, using Confluent as the provided. So far, this destination only supports plain auth (username + password, or API Key + Secret). Many things are still stubbed here, since the idea is to gather comments from Eng to improve the code in different iterations.
Testing
I recommend creating a trial account at https://confluent.io, set a sample cluster and follow the steps in the configuration.