This repository has been archived by the owner on Mar 17, 2024. It is now read-only.
Timeouts and retries #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deanwampler
approved these changes
Mar 11, 2019
.gitignore
Outdated
| *.iml | ||
| application.conf |
There was a problem hiding this comment.
Might want to add a linefeed at the end...
kafka-lag-exporter/README.md
Outdated
| * Add `kafka-client-timeout` config. | ||
| * Tune retry and timeout logic of Kafka admin client and consumer | ||
| * Use backoff strategy restarting offset collection logic when transient runtime exceptions are encountered | ||
| * Terminate when prometheus http server can't start (i.e. port can't be bound) |
There was a problem hiding this comment.
Consider "Prometheus HTTP server..."
| @@ -1,9 +1,9 @@ | |||
| <configuration> | |||
| <variable name="KAFKA_LAG_EXPORTER_LOG_LEVEL" value="${KAFKA_LAG_EXPORTER_LOG_LEVEL:-INFO}" /> | |||
| <variable name="KAFKA_LAG_EXPORTER_LOG_LEVEL" value="${KAFKA_LAG_EXPORTER_LOG_LEVEL:-DEBUG}" /> | |||
There was a problem hiding this comment.
I'm curious if you intended to use DEBUG as the default or was this left over from some testing?
| topicPartitions.map(tp => tp -> Measurements.Single(offsets.get(tp.asKafka).toLong,now)).toMap | ||
| } | ||
|
|
||
| /** | ||
| * Get last committed Consumer Group offsets for all group topic partitions. When a topic partition has no matched | ||
| * Consumer Group offset then a default offset of 0 is provided. | ||
| * @param groups A list of Consumer Groups to request offsets for. |
There was a problem hiding this comment.
Any reason you removed this Scaladoc @param entry?
There was a problem hiding this comment.
Just consistency. I didn't have it for the other methods. I've updated the description.
|
Thanks for the review @deanwampler ! :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6
PR features: