This repository has been archived by the owner on Mar 17, 2024. It is now read-only.
handle simple consumers #124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yazgoo
force-pushed
the
handle-simple-comsumers
branch
from
270c846 to
1e043be
Compare
|
If you rebase this PR I'll review it shortly. |
yazgoo
force-pushed
the
handle-simple-comsumers
branch
from
1e043be to
eca79d1
Compare
|
Done, but looks a lot like #128 though |
|
Closing in favour of #128. I appreciate the work though! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple consumers (like flink consumers) are not handleld by kafka-lag-exporter.
This fills GroupTopicPartition in the case of simple consumer so that lag monitoring works.