Skip to content
This repository was archived by the owner on Mar 17, 2024. It is now read-only.

Omit service account generation in Helm Chart when not using Strimzi auto detection #53

Closed
seglo opened this issue Aug 14, 2019 · 4 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@seglo
Copy link
Owner

seglo commented Aug 14, 2019

A service account is only required when using the Strimzi watcher so that a ClusterRole can be bound to it. When the Strimzi watch is disabled, do not generate a service account and remove the service account binding in the Deployment spec.

@seglo seglo added bug Something isn't working good first issue Good for newcomers labels Aug 14, 2019
@seglo seglo changed the title Omit service account when not using Strimzi auto detection Omit service account generation in Helm Chart when not using Strimzi auto detection Aug 14, 2019
@khorshuheng
Copy link
Contributor

May I pick this up?

@seglo
Copy link
Owner Author

seglo commented Sep 16, 2019

@khorshuheng Certainly.

For this issue I was thinking that we could make the service account optional during install. It's required when Strimzi is installed, so that we may assign it the appropriate roles, but it may also be useful in non-Strimzi installs if users don't want to use the default service account of a namespace.

We could add helm configuration with a default state of:

serviceAccount:
  create: false
  name: kafka-lag-exporter-serviceaccount

For the resource template itself we could use an or expression to create the resource when either the Strimzi watcher is enabled, or when serviceAccount.create == true. We will also need to optionally add the serviceAccount field in the Deployment template spec.

@seglo
Copy link
Owner Author

seglo commented Sep 16, 2019

Also, if you (or any of your colleagues) have any of your own ideas for the project please feel free to create an issue with a design for discussion.

khorshuheng added a commit to khorshuheng/kafka-lag-exporter that referenced this issue Sep 17, 2019
khorshuheng added a commit to khorshuheng/kafka-lag-exporter that referenced this issue Sep 17, 2019
seglo pushed a commit that referenced this issue Sep 19, 2019
* Omit service account generation when not using strimzi (#53)

* Add example usage
@seglo
Copy link
Owner Author

seglo commented Sep 19, 2019

Implemented in #64

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants