-
-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable nullable explicitly #572
Conversation
This PR fixes #552 |
@seesharper Could you review this PR? 🙏🏻 |
Thanks. Makes sense. |
@seesharper Thanks.
Let me check what could we do with this error 😞 |
There are the following target frameworks:
Okay, it looks like we have at least these two options:
@seesharper Which approach do you prefer? PS I've committed a fix using the first approach just to speed up merging if you are happy with it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
@seesharper Sorry for bothering you again about this small change. There is a version bump to 6.6.0, but no matching release exists. Could you release it please? |
@seesharper Thanks for the release! I've checked and it works perfectly 👍🏻 |
Hey,
We use LightInject(a source code package) as a built-in container for EasyNetQ.
We started a migration to Nullable Reference Types recently and observed build warnings because LightInject doesn't support them(and this is fine).
Could you consider adding
#nullable disable
pragma? It looks like the simplest way how these warnings could be suppressed.Anyway, thanks for LightInject 🚀