Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "cleanup" to the deployment script #44

Closed
mowtschan opened this issue Apr 14, 2021 · 2 comments
Closed

Add "cleanup" to the deployment script #44

mowtschan opened this issue Apr 14, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@mowtschan
Copy link
Contributor

Is your feature request related to a problem? Please describe.
If you try to deploy firmware with ./Firmware/ESP32/flash_esp32.sh
and it fails, you need to remove tmp.key file manually before you can run the script again.

Describe the solution you'd like
I would like to have a kind of "cleanup" in ./Firmware/ESP32/flash_esp32.sh:

cleanup() {
    echo "cleanup ..."
    rm -v "$KEYFILE"
}
...
set -e
trap cleanup INT TERM EXIT
...
@mowtschan mowtschan added the enhancement New feature or request label Apr 14, 2021
@Sn0wfreezeDev
Copy link
Member

At the moment the deployment script is mainly built to run from our app, which always removes the entire directory when finished.
You can make a pull request with this function for the manual installation and I'm happy to accept it.

mowtschan added a commit to mowtschan/openhaystack that referenced this issue Apr 15, 2021
@mowtschan
Copy link
Contributor Author

Should be fixed with PR #46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants