Revert storybook config to CJS #873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1a3b560 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
kjots
approved these changes
Aug 15, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sku storybook/sku build-storybookwere failing on storybook>7.1.0, specifically when loading sku's storybook files (main.jswhich importsconfig.js). These files were both converts to ESM during the storybook 7 migration when support for ESM was added formain.js. However, as of storybook 7.1.0, it appears that storybook no longer runsesbuild/registeron files fromnode_modules, which is likely how they were supporting ESM config, thus breaking the way sku injects storybook config.Short of changing how sku injects its storybook config (potentially emitting config to a
.storybookfolder and gitignoring it), the easiest solution in the meantime is to just revert these configs back to CJS.NOTE: I wasn't able to replicate this within sku's storybook fixture. Upgrading past storybook 7.1.0 results in the storybook CLI attempting to do things, but never finishing and showing no errors. However, I have replicated this issue in a sku consumer's app, and validated that the fix works.