fix(config): Add .mjs as an extension for Webpack to resolve #204
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#107 dropped
.mjs
from the list of extensions Webpack will resolve. This is causing problems for us -graphql
is in the import path of some of our components, and graphql/graphql-js#1272 is biting us. This cannot be fixed in userspace viawebapckConfig
inplayroom.config.js
, since the.mjs
extension needs to appear before the.js
extension, but the user-providedresolve.extensions
is concatenated to the end of Playroom's base Webpack config.An alternative solution would be to customize the way that
webpack-merge
mergesresolve.extensions
so that user-provided extensions always appear first. I'd be happy to pivot this PR to that if that's what the maintainers would prefer.