Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to eslint-plugin-jest 27 #79

Merged
merged 1 commit into from
Aug 31, 2022
Merged

Upgrade to eslint-plugin-jest 27 #79

merged 1 commit into from
Aug 31, 2022

Conversation

72636c
Copy link
Member

@72636c 72636c commented Aug 30, 2022

No description provided.

@@ -0,0 +1,14 @@
---
'eslint-config-seek': major
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong opinion on how we should semver this. The new recommended rule would fail on many existing projects but it is autofixable.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo I think major is appropriate given it is breaking despite being autofixable.

@72636c 72636c requested a review from a team August 31, 2022 01:50
@72636c 72636c merged commit 0b975d0 into master Aug 31, 2022
@72636c 72636c deleted the eslint-plugin-jest-27 branch August 31, 2022 01:54
@seek-oss-ci seek-oss-ci mentioned this pull request Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants