Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typescript-eslint monorepo ^6.0.0 #125

Merged
merged 11 commits into from
Aug 4, 2023

Conversation

samchungy
Copy link
Contributor

@samchungy samchungy commented Jul 27, 2023

Bump up to v6:

https://typescript-eslint.io/blog/announcing-typescript-eslint-v6/

https://github.com/typescript-eslint/typescript-eslint/tree/main/packages/eslint-plugin/docs/rules

Diff patch from v5's recommended to v6's recommended and stylistic configs
{
   '@typescript-eslint/adjacent-overload-signatures': '...',
+  '@typescript-eslint/array-type': '...',
   '@typescript-eslint/ban-ts-comment': '...',
+  '@typescript-eslint/ban-tslint-comment': '...',
   '@typescript-eslint/ban-types': '...',
+  '@typescript-eslint/class-literal-property-style': '...',
+  '@typescript-eslint/consistent-generic-constructors': '...',
+  '@typescript-eslint/consistent-indexed-object-style': '...',
+  '@typescript-eslint/consistent-type-assertions': '...',
+  '@typescript-eslint/consistent-type-definitions': '...',
   'no-array-constructor': '...',
   '@typescript-eslint/no-array-constructor': '...',
+  '@typescript-eslint/no-confusing-non-null-assertion': '...',
+  '@typescript-eslint/no-duplicate-enum-values': '...',
   'no-empty-function': '...',
   '@typescript-eslint/no-empty-function': '...',
   '@typescript-eslint/no-empty-interface': '...',
   '@typescript-eslint/no-explicit-any': '...',
   '@typescript-eslint/no-extra-non-null-assertion': '...',
-  'no-extra-semi': '...',
-  '@typescript-eslint/no-extra-semi': '...',
   '@typescript-eslint/no-inferrable-types': '...',
   'no-loss-of-precision': '...',
   '@typescript-eslint/no-loss-of-precision': '...',
   '@typescript-eslint/no-misused-new': '...',
   '@typescript-eslint/no-namespace': '...',
   '@typescript-eslint/no-non-null-asserted-optional-chain': '...',
-  '@typescript-eslint/no-non-null-assertion': '...',
   '@typescript-eslint/no-this-alias': '...',
   '@typescript-eslint/no-unnecessary-type-constraint': '...',
+  '@typescript-eslint/no-unsafe-declaration-merging': '...',
   'no-unused-vars': '...',
   '@typescript-eslint/no-unused-vars': '...',
   '@typescript-eslint/no-var-requires': '...',
   '@typescript-eslint/prefer-as-const': '...',
+  '@typescript-eslint/prefer-for-of': '...',
+  '@typescript-eslint/prefer-function-type': '...',
   '@typescript-eslint/prefer-namespace-keyword': '...',
   '@typescript-eslint/triple-slash-reference': '...',
}

@samchungy samchungy requested a review from a team as a code owner July 27, 2023 01:10
@changeset-bot
Copy link

changeset-bot bot commented Jul 27, 2023

🦋 Changeset detected

Latest commit: d0aa26f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-config-seek Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@samchungy samchungy changed the title fix: typescript-eslint monorepo ^6.0.0 typescript-eslint monorepo ^6.0.0 Jul 27, 2023
Copy link
Contributor

@askoufis askoufis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should bump the eslint peer dep too as support for v6 was dropped.

@samchungy
Copy link
Contributor Author

We should bump the eslint peer dep too as support for v6 was dropped.

good catch 🙌

@askoufis askoufis merged commit b09afa8 into seek-oss:master Aug 4, 2023
@seek-oss-ci seek-oss-ci mentioned this pull request Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants