New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable eslint rule: no-return-await #59

Closed

samchungy opened this issue May 18, 2021 · 0 comments · Fixed by #74

Contributor

samchungy commented May 18, 2021

Discovered this write up on why we shouldn't be erroring return await from within functions. If anything, it should now only be a warning.

https://github.com/goldbergyoni/nodebestpractices/blob/master/sections/errorhandling/returningpromises.md

72636c added a commit that referenced this issue


          Turn off no-return-await

3ef3cd5

Closes #59.

72636c mentioned this issue

Turn off no-return-await #74

Merged

72636c closed this as completed in #74

72636c added a commit that referenced this issue


          Turn off no-return-await (#74)

3d09dde

Closes #59.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment