security suggestion from github

themes/doubletime/doubletime.theme.bash

@@ -1,4 +1,5 @@
 # shellcheck shell=bash
+# shellcheck disable=SC2034,SC2154
 
 SCM_THEME_PROMPT_DIRTY=''
 SCM_THEME_PROMPT_CLEAN=''
@@ -7,23 +8,23 @@ SCM_SVN_CHAR="${bold_cyan}⑆${normal}"
 SCM_HG_CHAR="${bold_red}☿${normal}"
 SCM_THEME_PROMPT_PREFIX=""
 SCM_THEME_PROMPT_SUFFIX=""
-if [ ! -z $RVM_THEME_PROMPT_COLOR ]; then
-	RVM_THEME_PROMPT_COLOR=$(eval echo $$(echo ${RVM_THEME_PROMPT_COLOR}))
+if [[ -n "$RVM_THEME_PROMPT_COLOR" ]]; then
+	RVM_THEME_PROMPT_COLOR=$(eval "echo $$(echo ${RVM_THEME_PROMPT_COLOR})")
 else
 	RVM_THEME_PROMPT_COLOR="${red}"
 fi
 RVM_THEME_PROMPT_PREFIX="(${RVM_THEME_PROMPT_COLOR}rb${normal}: "
 RVM_THEME_PROMPT_SUFFIX=") "
-if [ ! -z $VIRTUALENV_THEME_PROMPT_COLOR ]; then
-	VIRTUALENV_THEME_PROMPT_COLOR=$(eval echo $$(echo ${VIRTUALENV_THEME_PROMPT_COLOR}))
+if [[ -n "$VIRTUALENV_THEME_PROMPT_COLOR" ]]; then
+	VIRTUALENV_THEME_PROMPT_COLOR=$(eval "echo $$(echo ${VIRTUALENV_THEME_PROMPT_COLOR})")
 else
 	VIRTUALENV_THEME_PROMPT_COLOR="${green}"
 fi
 VIRTUALENV_THEME_PROMPT_PREFIX="(${VIRTUALENV_THEME_PROMPT_COLOR}py${normal}: "
 VIRTUALENV_THEME_PROMPT_SUFFIX=") "
 
-if [ ! -z $THEME_PROMPT_HOST_COLOR ]; then
-	THEME_PROMPT_HOST_COLOR=$(eval echo $$(echo ${THEME_PROMPT_HOST_COLOR}))
+if [[ -n "$THEME_PROMPT_HOST_COLOR" ]]; then
+	THEME_PROMPT_HOST_COLOR=$(eval "echo $$(echo ${THEME_PROMPT_HOST_COLOR})")
 else
 	THEME_PROMPT_HOST_COLOR="$blue"
 fi