Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix polar scatter plot #9

Merged
merged 4 commits into from
May 31, 2024
Merged

Bugfix polar scatter plot #9

merged 4 commits into from
May 31, 2024

Conversation

bvandekerkhof
Copy link
Collaborator

Description

  • Bugfix for plot polar scatter plot methods in Meteorology, adding color cycle.
  • Adding functionality to allow for Sensors with different number of observations to be plotted as well when the function is called from a MeterorologyGroup object.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Jupyter Notebooks

No changes to Jupyter notebooks

How Has This Been Tested?

As it is plotting code we do not have tests in place. So it is tested by examining an example dataset and found that the plots were as expected.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • [N/A] I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Signed-off-by: bvandekerkhof <[email protected]>
Signed-off-by: bvandekerkhof <[email protected]>
@bvandekerkhof bvandekerkhof requested a review from mattj89 May 31, 2024 12:18
Copy link
Collaborator

@mattj89 mattj89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked this through, all looks good. All tests still passing (though no tests associated with plotting). Many thanks.

@mattj89 mattj89 merged commit 318a268 into main May 31, 2024
13 of 16 checks passed
@mattj89 mattj89 deleted the bugfix_polar_scatter_plot branch May 31, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants