Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supporting more python versions #6

Merged
merged 6 commits into from
Mar 13, 2024
Merged

Supporting more python versions #6

merged 6 commits into from
Mar 13, 2024

Conversation

bvandekerkhof
Copy link
Collaborator

Description

Also adding support for Python 3.9 and 3.10.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

mattj89
mattj89 reviewed Mar 12, 2024
View reviewed changes
Copy link
Collaborator

@mattj89 mattj89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good- thanks. Let me know what you prefer to do about the pandas/datetime related warnings.

@bvandekerkhof bvandekerkhof requested a review from mattj89 March 13, 2024 10:53
mattj89
mattj89 approved these changes Mar 13, 2024
View reviewed changes
Copy link
Collaborator

@mattj89 mattj89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great- thanks for resolving these.

@bvandekerkhof bvandekerkhof merged commit f9ef804 into main Mar 13, 2024
2 checks passed
@bvandekerkhof bvandekerkhof deleted the python_support branch May 23, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattj89 mattj89 mattj89 approved these changes

Assignees

@mattj89 mattj89

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bvandekerkhof @mattj89