Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply thinning #10

Merged
merged 13 commits into from
Jul 2, 2024
Merged

Apply thinning #10

merged 13 commits into from
Jul 2, 2024

Conversation

mattj89
Copy link
Collaborator

@mattj89 mattj89 commented Jun 18, 2024

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Updated to account for small change in functionality in openMCMC- now the user can specify a thinning frequency for the MCMC chain, and the sampler will store only every n_thin iterations of the chain. This option is now exposed to the user in pyelq.model, defaulting to 1. Also, the gitignore was updated to prevent pushing of local .vscode settings.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Jupyter Notebooks

No changes to Jupyter notebooks.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A: All existing model tests pass using with the modified code (using the default n_thin = 1).
  • Test B: Data analysis run using the modified code is successful.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@mattj89 mattj89 requested a review from davidrandell84 June 18, 2024 09:49
@mattj89 mattj89 merged commit 573342b into main Jul 2, 2024
9 checks passed
@mattj89 mattj89 deleted the apply_thinning branch July 2, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants