feat: Bookmarks #83
Merged
feat: Bookmarks #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't like how it looks & think being able to filter by bookmarked is probably sufficient. Slightly harder to learn, but once you do learn it's just as easy and has more features.
Updates the sidebar links when filtering by Bookmarked
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Also - feel free to squash and merge my code PRs. I tend to have a lot of commits while I work through things, so it can be cluttered. No need to have a messy main branch. |
Closed
|
I'll try to address this within this week. But in the meantime if you want to squash your commits that would be great, though I wasn't really tidy when I started working by myself haha. But now that we're open to external collaboration I'd like that to change |
|
No worries — no rush on merging the changes. I need to actually get around to writing the safe harbor content (you know - the original point of me looking at this pr lol). I don't have permissions to squash. It's an option you can select when merging the PR - Doesn't change anything, just combines all the commits into a single item in the git history. |
mattaereal
added a commit
that referenced
this pull request
Nov 1, 2024
* add SEAL logo as favicon * docs: Update README ##pull-requests * fix: Fix typo * fix: typos in pr_template * feat: improved tag generation * feat: Update tag display system * Sort tags alphabetically * Remove "Selected Articles" * When a tag is displayed, only show articles matching the tag * Fixed CSS on tags-dropdown * feat: remove duplicate code & document methods * Functionality remains, as far as I can tell, the same. I mostly just removed a few duplicate methods related to tagsList and added documentation to make the code easier for new readers. * refactor: move JS and CSS to seperate files * style: Added margin around page-tags * refactor: Extract tag initialization logic into seperate methods * fix: announcement-stripe overflowing at lower horizontal resolutions Also fixed layering issue due to background transparency * feat: implemented AND selection for tags. The code for OR selection was just commented out since I'm not sure if others actually wanted this, or if it was just me. Can be reverted if so desired. * feat: remove HTML styling on tag-search Better to have all styles in the .css file * Updating wordlist.txt and some markdown linting fixes * Jump of line fix in README * Updating wordlist * Adding a few more words to wordlist.txt * feat: Bookmarks (#83) * feat: add bookmarked to tags filtering * revert: remove bookmarked section from ToC I don't like how it looks & think being able to filter by bookmarked is probably sufficient. Slightly harder to learn, but once you do learn it's just as easy and has more features. * fix: Fix bug where deselcting tags removes all filters * fix: refresh sidebar when bookmarking Updates the sidebar links when filtering by Bookmarked --------- Co-authored-by: Mehdi Zerouali <[email protected]> Co-authored-by: Robert MacWha <[email protected]> Co-authored-by: Fredrik Svantes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frameworks PR Checklist
Changes Summary
I ended up combining bookmarks with the tags because (a) it makes for a cleaner UI and (b) it grants more functionality - filtering bookmarked pages by their tags. I do note that it makes for a less intuitive UX (specifically, when first bookmarking an article users receive no feedback), but the hit to the UI from having a separate bookmark section seemed worse than this poor UX.
Let me know if you think it ought to be done differently, since I'm not thrilled with this implementation.
Comparison