New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

componentWillUnmount: destroy editor #92

Merged

securingsincity merged 1 commit into securingsincity:master from juttle:destroy-editor

Mar 20, 2016

Contributor

davidvgalbraith commented Mar 8, 2016

The editor leaks event listeners if you just null it: ajaxorg/ace#2085. Calling destroy() triggers the full cleanup, so let's do that.


          componentWillUnmount: destroy editor

71d3526

securingsincity merged commit 71d3526 into securingsincity:master

Owner

securingsincity commented Mar 20, 2016

thanks @davidvgalbraith !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet