Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add proxy aware metadata #624

Merged
merged 3 commits into from
Sep 17, 2024
Merged

add proxy aware metadata #624

merged 3 commits into from
Sep 17, 2024

Conversation

miyunari
Copy link
Contributor

Signed-off-by: Janine Olear <[email protected]>
@miyunari miyunari requested a review from osmman September 16, 2024 13:24
@miyunari miyunari self-assigned this Sep 16, 2024
Signed-off-by: Janine Olear <[email protected]>
Copy link
Contributor

@osmman osmman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update these locations too

@miyunari
Copy link
Contributor Author

please update these locations too

ah sry, overlooked those 😅 Changed them now :)

@miyunari miyunari requested a review from osmman September 17, 2024 09:18
@openshift-ci openshift-ci bot added the lgtm label Sep 17, 2024
Copy link

openshift-ci bot commented Sep 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: miyunari, osmman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 51eeb98 into main Sep 17, 2024
17 checks passed
@osmman osmman deleted the proxy_aware_metadata branch September 17, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants