Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unifying CLI Servers #618

Merged
merged 12 commits into from
Sep 20, 2024
Merged

Unifying CLI Servers #618

merged 12 commits into from
Sep 20, 2024

Conversation

tommyd450
Copy link
Contributor

All of our CLI Servers are now one again, tuftool lacks multiarch so I added the entry manually rather than using the method as it would add multiple empty entries to the CLI Downloads Page on cluster.

@tommyd450
Copy link
Contributor Author

/test tas-operator-e2e

internal/clidownload/component.go Outdated Show resolved Hide resolved
cmd/main.go Outdated Show resolved Hide resolved
internal/clidownload/component.go Outdated Show resolved Hide resolved
@osmman
Copy link
Contributor

osmman commented Sep 20, 2024

Please this code into cli e2e test. It will dump state of common objects from namespace which could be useful to find root of problem.

AfterEach(func() {
    if CurrentSpecReport().Failed() && support.IsCIEnvironment() {
	    support.DumpNamespace(ctx, cli, "trusted-artifact-signer")
    }
})

@tommyd450
Copy link
Contributor Author

/test tas-operator-e2e

@osmman
Copy link
Contributor

osmman commented Sep 20, 2024

@tommyd450 I see this error message in events:

'Failed to apply default image tag "quay.io/securesign/client-server@sha256:8d98cc4648153c1aebbf2772139d05e560a150bf5070fd8e49057b2ac6dab67":
  couldn''t parse image reference "quay.io/securesign/client-server@sha256:8d98cc4648153c1aebbf2772139d05e560a150bf5070fd8e49057b2ac6dab67":
  invalid checksum digest length'

https://github.com/securesign/secure-sign-operator/actions/runs/10960182513/artifacts/1958498749

@tommyd450
Copy link
Contributor Author

/test tas-operator-e2e

@osmman
Copy link
Contributor

osmman commented Sep 20, 2024

/override ci/prow/tas-operator-e2e

Copy link

openshift-ci bot commented Sep 20, 2024

@osmman: Overrode contexts on behalf of osmman: ci/prow/tas-operator-e2e

In response to this:

/override ci/prow/tas-operator-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Sep 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: osmman, tommyd450

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit a511fd9 into main Sep 20, 2024
15 checks passed
@osmman osmman deleted the tdalton/cliDownloadChanges branch September 20, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants