Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SECURESIGN-1221 | SBJ Not reaching segment endpoint #570

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

JasonPowr
Copy link
Contributor

This is part two of a two part fix, opening as a draft for know until I can get a image for sbj that includes my fixes :)

Copy link

openshift-ci bot commented Aug 22, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

openshift-ci bot commented Aug 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JasonPowr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JasonPowr JasonPowr marked this pull request as ready for review August 26, 2024 08:17
@openshift-ci openshift-ci bot requested review from bouskaJ and lance August 26, 2024 08:17
@JasonPowr JasonPowr force-pushed the fix-sbj-not-reaching-segment branch from 5c7015c to 37eb796 Compare August 26, 2024 13:40
@JasonPowr JasonPowr requested a review from osmman August 26, 2024 16:09
@osmman
Copy link
Contributor

osmman commented Aug 28, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 28, 2024
@JasonPowr JasonPowr merged commit 5c5ee85 into main Aug 28, 2024
13 of 14 checks passed
Copy link

openshift-ci bot commented Aug 28, 2024

@JasonPowr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/tas-operator-e2e 8f6936c link unknown /test tas-operator-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@osmman osmman deleted the fix-sbj-not-reaching-segment branch September 17, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants