SECURESIGN-1250 | Targets are not coming up with monitoring enabled. #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osmman
reviewed
Jul 22, 2024
JasonPowr
force-pushed
the
fix-service-monitors
branch
from
db4bc8b to
80d5f9a
Compare
osmman
reviewed
Jul 22, 2024
| @@ -44,7 +40,7 @@ func (i createServiceAction) Handle(ctx context.Context, instance *rhtasv1alpha1 | |||
| ) | |||
|
|
|||
| labels := constants.LabelsFor(actions.LogSignerComponentName, actions.LogsignerDeploymentName, instance.Name) | |||
| logsignerService := k8sutils.CreateService(instance.Namespace, actions.LogsignerDeploymentName, actions.MonitoringPortName, actions.MonitoringPort, labels) | |||
| logsignerService := k8sutils.CreateService(instance.Namespace, actions.LogsignerDeploymentName, actions.MonitoringPortName, actions.MonitoringPort, actions.MonitoringPort, labels) | |||
There was a problem hiding this comment.
trillian-logsigner should provide 2 service ports. GRPC 8091 which is missing and 8090 for HTTP metrics
There was a problem hiding this comment.
currently there is only 8090 provided
|
maybe we should rename |
JasonPowr
force-pushed
the
fix-service-monitors
branch
from
80d5f9a to
9c8df05
Compare
osmman
approved these changes
Jul 22, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JasonPowr, osmman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test tas-operator-e2e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pr to fix the issue where service monitor targets are not coming up, caused by a change in the naming for the service ports.