Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Rotation the signer key for Rekor service #513

Merged
merged 1 commit into from
Jul 20, 2024

Conversation

osmman
Copy link
Contributor

@osmman osmman commented Jul 17, 2024

Depends on: #512

Copy link

openshift-ci bot commented Jul 17, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@osmman osmman force-pushed the doc-rekor-key-rotation branch 2 times, most recently from 6dd6d66 to 4f6aa7b Compare July 17, 2024 14:44
@osmman osmman force-pushed the doc-rekor-key-rotation branch from 4f6aa7b to 03a0d96 Compare July 17, 2024 15:43
@osmman osmman marked this pull request as ready for review July 17, 2024 15:44
@openshift-ci openshift-ci bot requested review from JasonPowr and sallyom July 17, 2024 15:44
@osmman osmman requested a review from lance July 17, 2024 15:44
Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - though you might want to put a warning or note at the top that this procedure is incomplete and should not be done until the final step (updating TUF) is possible and documented.

Copy link

openshift-ci bot commented Jul 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance, osmman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 0f237c9 into main Jul 20, 2024
11 checks passed
@osmman osmman deleted the doc-rekor-key-rotation branch July 20, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants