Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pass proxy configuration to operands #466

Closed
wants to merge 1 commit into from

Conversation

miyunari
Copy link
Contributor

@openshift-ci openshift-ci bot requested review from sabre1041 and tommyd450 June 25, 2024 16:08
Copy link

openshift-ci bot commented Jun 25, 2024

Hi @miyunari. Thanks for your PR.

I'm waiting for a securesign member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lance
Copy link
Member

lance commented Jun 25, 2024

/ok-to-test

@lance
Copy link
Member

lance commented Jun 25, 2024

/approve

Copy link

openshift-ci bot commented Jun 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance, miyunari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@miyunari miyunari force-pushed the feat/enable_proxy branch from 0da86d4 to a296d50 Compare June 26, 2024 07:53
@osmman
Copy link
Contributor

osmman commented Jun 26, 2024

/lgtm

@miyunari
Copy link
Contributor Author

Hi @osmman - thanks for your review. Do you know what is going on with the ci pipeline tests?

@osmman
Copy link
Contributor

osmman commented Jun 26, 2024

Hi @osmman - thanks for your review. Do you know what is going on with the ci pipeline tests?

Hi, problem is that PR is from forked repository so Github action do not enable to access to CI's secrets. Current solution is to create new PR from current securesign/secure-sign-operator repo.

@miyunari
Copy link
Contributor Author

Hi @osmman - thanks for your review. Do you know what is going on with the ci pipeline tests?

Hi, problem is that PR is from forked repository so Github action do not enable to access to CI's secrets. Current solution is to create new PR from current securesign/secure-sign-operator repo.

Ah ok, thanks for explaining @osmman 😃 Does this mean I have to create a new branch or can this be merged anyway? 🙂

@osmman
Copy link
Contributor

osmman commented Jun 26, 2024

Hi @osmman - thanks for your review. Do you know what is going on with the ci pipeline tests?

Hi, problem is that PR is from forked repository so Github action do not enable to access to CI's secrets. Current solution is to create new PR from current securesign/secure-sign-operator repo.

Ah ok, thanks for explaining @osmman 😃 Does this mean I have to create a new branch or can this be merged anyway? 🙂

Please create a new branch, Kind deployment and upgrade operator contains most of our e2e tests.

@miyunari
Copy link
Contributor Author

Ok :)

@miyunari miyunari closed this Jun 26, 2024
@miyunari miyunari deleted the feat/enable_proxy branch June 26, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants