-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: pass proxy configuration to operands #466
Conversation
Hi @miyunari. Thanks for your PR. I'm waiting for a securesign member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance, miyunari The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Janine Olear <[email protected]>
0da86d4
to
a296d50
Compare
/lgtm |
Hi @osmman - thanks for your review. Do you know what is going on with the ci pipeline tests? |
Hi, problem is that PR is from forked repository so Github action do not enable to access to CI's secrets. Current solution is to create new PR from current securesign/secure-sign-operator repo. |
Ah ok, thanks for explaining @osmman 😃 Does this mean I have to create a new branch or can this be merged anyway? 🙂 |
Please create a new branch, Kind deployment and upgrade operator contains most of our e2e tests. |
Ok :) |
jira: https://issues.redhat.com/browse/SECURESIGN-1038