-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SECURESIGN-1014 | Add support for Trusted Timestamp Authorities in SecureSign #456
Conversation
75de16f
to
171b90d
Compare
a0bb1a0
to
1282868
Compare
4150c71
to
3259955
Compare
0959e74
to
0e16cd0
Compare
21c3783
to
080759a
Compare
/test tas-operator-e2e |
a481720
to
d53a47d
Compare
7bead72
to
513bfc9
Compare
/test tas-operator-e2e |
1 similar comment
/test tas-operator-e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I installed sample Securesign resource and I am getting this status condition on TSA object:
status:
conditions:
- message: ''
reason: Ready
status: 'True'
type: Ready
- message: ''
reason: Pending
status: Unknown
type: TSASignerCondition
- message: Ingress created
reason: Creating
status: 'False'
type: TSAServerCondition
It looks like that TSA service has been deployed correctly but status of TSASignerCondition and TSAServerCondition are not positive.
513bfc9
to
04a08c5
Compare
@osmman Should be resolved now, I also made those changes to the tests
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JasonPowr, osmman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
Opening this as a draft pr, so far this is just the basic deployment of the Timestamp Authority. just looking for some feedback. jira: https://issues.redhat.com/browse/SECURESIGN-1014
Testing
--timestamp-server-url=$TSA_URL
egcertificate chain
usingcurl https://<tsa-url>/api/v1/timestamp/certchain > ts_chain.pem
, then run thecosign verify
cmd like so:TODO
improve e2e and upgrade test