Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add liveness and readiness probes #408

Merged
merged 3 commits into from
May 31, 2024
Merged

Add liveness and readiness probes #408

merged 3 commits into from
May 31, 2024

Conversation

osmman
Copy link
Contributor

@osmman osmman commented May 31, 2024

Add probes for rekor-server and trillian-db services

Fixing broken readines probe on trillian-db deployment which fails because environment values has not been resolved.

Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

controllers/trillian/utils/trillian-db.go Outdated Show resolved Hide resolved
controllers/trillian/utils/trillian-db.go Outdated Show resolved Hide resolved
Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented May 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance, osmman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 6c4bef6 into main May 31, 2024
11 checks passed
@osmman osmman deleted the add-probes branch May 31, 2024 19:27
@osmman
Copy link
Contributor Author

osmman commented Jun 3, 2024

/cherry-pick release-1.0

@openshift-cherrypick-robot

@osmman: new pull request created: #411

In response to this:

/cherry-pick release-1.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants