Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove analytics field from Securesign sample #372

Merged
merged 1 commit into from
May 15, 2024

Conversation

osmman
Copy link
Contributor

@osmman osmman commented May 15, 2024

No description provided.

Copy link

openshift-ci bot commented May 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: osmman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@osmman osmman requested review from bouskaJ and JasonPowr and removed request for lkatalin May 15, 2024 09:28
@JasonPowr
Copy link
Contributor

Found one more example to it here: https://github.com/securesign/secure-sign-operator/blob/main/README.md?plain=1#L136

Only the readme but should probably be removed :)

@osmman osmman force-pushed the sample-remove-analytics branch from e5adce2 to 515c229 Compare May 15, 2024 09:42
@osmman
Copy link
Contributor Author

osmman commented May 15, 2024

Found one more example to it here: https://github.com/securesign/secure-sign-operator/blob/main/README.md?plain=1#L136

Only the readme but should probably be removed :)

README fixed

@JasonPowr
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 15, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 4487365 into main May 15, 2024
10 checks passed
@osmman osmman deleted the sample-remove-analytics branch June 3, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants