Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pprof-address option to expose pprof server #334

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Conversation

osmman
Copy link
Contributor

@osmman osmman commented Apr 23, 2024

Add --pprof-address option to expose the pprof server. Default is empty string which disables the pprof server.

Fixes unused value ffrom --metrics-bind-address option.

/cc @lance @JasonPowr

@openshift-ci openshift-ci bot requested review from sabre1041 and sallyom April 23, 2024 13:07
Copy link
Contributor

@JasonPowr JasonPowr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Apr 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JasonPowr, osmman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@osmman
Copy link
Contributor Author

osmman commented Apr 23, 2024

/override ci/prow/tas-operator-e2e

Copy link

openshift-ci bot commented Apr 23, 2024

@osmman: Overrode contexts on behalf of osmman: ci/prow/tas-operator-e2e

In response to this:

/override ci/prow/tas-operator-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JasonPowr JasonPowr merged commit 0fdd8ed into main Apr 24, 2024
9 of 10 checks passed
@osmman osmman deleted the add-pprof-option branch June 3, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants