Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rises a memory limit to 256Mi on manager's container #333

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Conversation

osmman
Copy link
Contributor

@osmman osmman commented Apr 19, 2024

@Gregory-Pereira
Copy link
Contributor

Gregory-Pereira commented Apr 19, 2024

@osmman
Copy link
Contributor Author

osmman commented Apr 22, 2024

There are more references, please include: https://github.com/securesign/secure-sign-operator/blob/main/config/default/manager_auth_proxy_patch.yaml#L46-L50

I don't think there is a need to adjust this limit. It is resource limit for kube-rbac-proxy container and our problem has been caused in manager container

Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Apr 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance, osmman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@osmman
Copy link
Contributor Author

osmman commented Apr 22, 2024

/override ci/prow/tas-operator-e2e

Copy link

openshift-ci bot commented Apr 22, 2024

@osmman: Overrode contexts on behalf of osmman: ci/prow/tas-operator-e2e

In response to this:

/override ci/prow/tas-operator-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@osmman osmman merged commit af6336f into main Apr 22, 2024
9 of 10 checks passed
@osmman osmman deleted the SECURESIGN-833 branch April 22, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants