-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add-missing-metadata #331
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JasonPowr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The ci/prow/tas-operator-e2e test is failing because the namespace is hard-coded in https://github.com/securesign/secure-sign-operator/blob/main/config/samples/rhtas_v1alpha1_securesign.yaml#L9
I have a fix for this in this pr: #301, specifically here: |
features.operators.openshift.io/token-auth-azure: "false" | ||
features.operators.openshift.io/token-auth-gcp: "false" | ||
repository: https://github.com/securesign/secure-sign-operator | ||
support: Red Hat | ||
name: rhtas-operator.v0.0.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v0.0.1
look like some remaining from old release
/lgtm |
/override ci/prow/tas-operator-e2e |
@osmman: Overrode contexts on behalf of osmman: ci/prow/tas-operator-e2e In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This pr makes the changes necessary to display missing metadata in the operator marketplace
Jira: https://issues.redhat.com/browse/SECURESIGN-801
Testing
Here is an CatalogSource yaml definition you can use if you want to test, with my FBC image