Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add service monitors to log server and log signer #320

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

JasonPowr
Copy link
Contributor

This pr adds service monitors to log server and log signer.

Testing

  1. Deploy operator
  2. Create CRD with this in it:
  trillian:
    monitoring:
      enabled: true
  1. Targets will come up, and you can see metrics in Observe -> Metrics

@openshift-ci openshift-ci bot requested review from bouskaJ and sallyom April 16, 2024 08:49
Copy link

openshift-ci bot commented Apr 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JasonPowr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JasonPowr JasonPowr changed the title enable-monitoring-for-trillian feat: add service monitors to log server and log signer Apr 16, 2024
@osmman
Copy link
Contributor

osmman commented Apr 17, 2024

/lgtm

@osmman
Copy link
Contributor

osmman commented Apr 17, 2024

/override ci/prow/tas-operator-e2e

Copy link

openshift-ci bot commented Apr 17, 2024

@osmman: Overrode contexts on behalf of osmman: ci/prow/tas-operator-e2e

In response to this:

/override ci/prow/tas-operator-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@osmman osmman merged commit 6f62188 into main Apr 17, 2024
7 of 10 checks passed
@osmman osmman deleted the enable-monitoring-for-trillian branch April 17, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants