Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Securesign 297] Backup and Restore Docs #277

Merged
merged 2 commits into from
Apr 18, 2024
Merged

[Securesign 297] Backup and Restore Docs #277

merged 2 commits into from
Apr 18, 2024

Conversation

tommyd450
Copy link
Contributor

@tommyd450 tommyd450 commented Mar 20, 2024

First draft of these if someone has the cycles to give this a test please ping me here or on slack with questions.

@openshift-ci openshift-ci bot requested review from JasonPowr and sabre1041 March 20, 2024 11:58
Copy link
Contributor

@JasonPowr JasonPowr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some small things that stood out to, looks good overall. :)
Should: docs/Scheduled-Backup.md be empty?

# Backup Procedure
## Prerequisites
- Successfully installed and configured OADP Operator.
- See OADP-Install.md.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should link to the OADP-Install.md

docs/Backup.md Outdated Show resolved Hide resolved
docs/OADP-Install.md Outdated Show resolved Hide resolved
docs/Restore.md Show resolved Hide resolved
docs/Restore.md Outdated Show resolved Hide resolved
docs/samples/Backup_Sample.yaml Show resolved Hide resolved
@tommyd450 tommyd450 changed the title [Securesign 297] Back up and Restore Docs [Securesign 297] Backup and Restore Docs Mar 20, 2024
docs/Restore.md Outdated Show resolved Hide resolved
docs/OADP-Install.md Outdated Show resolved Hide resolved
docs/OADP-Install.md Outdated Show resolved Hide resolved
docs/Backup.md Outdated Show resolved Hide resolved
docs/Backup.md Outdated Show resolved Hide resolved
@osmman
Copy link
Contributor

osmman commented Mar 25, 2024

Hi @tommyd450, I unable to restore TAS instance because OADP will not recreate deleted PVCs.

I did these steps:

  • create backup of rhtas-backup namespace (I install there TAS stack)
apiVersion: velero.io/v1
kind: Backup
metadata:
  name: backup-0001
  labels:
    velero.io/storage-location: default
  namespace: openshift-adp
spec:
  hooks: {}
  includedNamespaces:
  - rhtas-backup
  includedResources: [] 
  excludedResources: [VolumeSnapshots]
  storageLocation: default
  ttl: 720h0m0s
  • dissable rhtas operator
  • delete rhtas-backup
  • delete rekor-backup-pvc and trillian-mysql PVC
  • create restore object:
apiVersion: velero.io/v1
kind: Restore
metadata:
  name: restore-0002
  namespace: openshift-adp
spec:
  backupName: backup-0001
  includedResources: [] 
  excludedResources:
  - nodes
  - events
  - events.events.k8s.io
  - backups.velero.io
  - restores.velero.io
  - resticrepositories.velero.io
  restorePVs: true 
  existingResourcePolicy: Update

docs/Backup.md Outdated Show resolved Hide resolved
docs/Restore.md Outdated Show resolved Hide resolved
docs/Restore.md Outdated Show resolved Hide resolved
@tommyd450 tommyd450 requested a review from osmman April 17, 2024 13:32
@tommyd450 tommyd450 requested a review from JasonPowr April 17, 2024 13:32
Copy link
Contributor

@osmman osmman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Apr 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: osmman, tommyd450

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@osmman
Copy link
Contributor

osmman commented Apr 18, 2024

/override ci/prow/tas-operator-e2e

Copy link

openshift-ci bot commented Apr 18, 2024

@osmman: Overrode contexts on behalf of osmman: ci/prow/tas-operator-e2e

In response to this:

/override ci/prow/tas-operator-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@osmman osmman merged commit 77fd586 into main Apr 18, 2024
6 of 8 checks passed
@osmman osmman deleted the SECURESIGN-297 branch April 18, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants