Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix validation error #261

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Fix validation error #261

merged 1 commit into from
Mar 15, 2024

Conversation

bouskaJ
Copy link
Collaborator

@bouskaJ bouskaJ commented Mar 12, 2024

No description provided.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 12, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bouskaJ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bouskaJ bouskaJ force-pushed the fix_validation_error branch from 282542e to 63bad82 Compare March 12, 2024 08:39
@bouskaJ bouskaJ marked this pull request as ready for review March 12, 2024 09:02
@openshift-ci openshift-ci bot requested review from cooktheryan and tommyd450 March 12, 2024 09:02
@bouskaJ bouskaJ requested a review from osmman March 12, 2024 09:02
@bouskaJ
Copy link
Collaborator Author

bouskaJ commented Mar 12, 2024

/retest

@osmman
Copy link
Contributor

osmman commented Mar 12, 2024 •
edited
Loading

Please can you create a unit tests for that action. It is hard to undertand how it should work and I am not sure if it will handle correctly case when key will be removed from spec.

For mocking client and recorder you can use https://pkg.go.dev/sigs.k8s.io/controller-runtime/pkg/client/fake

@osmman
Copy link
Contributor

osmman commented Mar 12, 2024

/retest

@bouskaJ bouskaJ force-pushed the fix_validation_error branch 2 times, most recently from 13cace1 to c1b4613 Compare March 14, 2024 13:56
@bouskaJ bouskaJ force-pushed the fix_validation_error branch from c1b4613 to b46854a Compare March 14, 2024 13:58
osmman
osmman reviewed Mar 14, 2024
View reviewed changes
controllers/tuf/actions/generate_cert_test.go
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be nice to extend tests to cover CanHandle method and scenarios which should not trigger action

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will create a new PR to solve that

@osmman
Copy link
Contributor

osmman commented Mar 15, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 15, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit f8dd8b4 into main Mar 15, 2024
10 checks passed
@osmman osmman deleted the fix_validation_error branch April 5, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osmman osmman osmman left review comments

@cooktheryan cooktheryan Awaiting requested review from cooktheryan

@tommyd450 tommyd450 Awaiting requested review from tommyd450

Assignees

@osmman osmman

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bouskaJ @osmman