-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SECURESIGN-589 | Fulcio OIDC issuers configuration does not show in Web Form #257
Conversation
c829ae4
to
7d156d7
Compare
/test tas-operator-e2e |
7d156d7
to
0d420cd
Compare
/test tas-operator-e2e |
/retest |
0d420cd
to
ba7585b
Compare
Dont merge this yet, I believe its only passing openshift e2e because I added this line:
to the end of the test script |
This error is showing up in e2e on openshift
|
I believe the ci in openshift is failing because its building and deploying an fbc image, and in the fbc image its using an older version of the operator that wont have the necessary changes to the api to support this new fulcio config. Looking at the ci run its using the image: So we kinda have a chicken and egg thing here... |
ba7585b
to
0935895
Compare
0935895
to
ae7b567
Compare
I think the best option to deal with this is to merge this pr, get a new operator image from konflux, I can then update the bundle and fbc images accordingly. wdyt? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JasonPowr, lance The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test tas-operator-e2e |
This pr fixes the issue laid out in this jira https://issues.redhat.com/browse/SECURESIGN-589, The main issues was with how the issuer info was stored in the api.