Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SECURESIGN-655] Enable OIDCs with private or self-signed certificates #256

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

osmman
Copy link
Contributor

@osmman osmman commented Mar 8, 2024

Resolve #206

Copy link

openshift-ci bot commented Mar 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: osmman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Mar 8, 2024
@osmman osmman marked this pull request as draft March 8, 2024 10:32
@osmman osmman marked this pull request as ready for review March 8, 2024 10:35
@openshift-ci openshift-ci bot requested review from Gregory-Pereira and lance March 8, 2024 10:35
@cooktheryan cooktheryan requested a review from bouskaJ March 11, 2024 14:37
@bouskaJ
Copy link
Collaborator

bouskaJ commented Mar 11, 2024

/LGTM

@openshift-ci openshift-ci bot removed the lgtm label Mar 12, 2024
@bouskaJ
Copy link
Collaborator

bouskaJ commented Mar 13, 2024

/LGTM

@openshift-ci openshift-ci bot added the lgtm label Mar 13, 2024
@osmman
Copy link
Contributor Author

osmman commented Mar 13, 2024

/test all

@openshift-merge-bot openshift-merge-bot bot merged commit 6a25f4a into main Mar 13, 2024
10 checks passed
@osmman osmman deleted the fulcio-oidc-ca branch April 5, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fulcio CA certificate issue
3 participants