Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LocalObejctReference to v1alpha1 api #244

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

osmman
Copy link
Contributor

@osmman osmman commented Mar 4, 2024

Make Name field mandatory and remove TODO: Add other useful fields. apiVersion, kind, uid? from OpenAPI description, which comes from v1.LocalObjectReferenc

@osmman osmman requested a review from bouskaJ March 4, 2024 10:07
@openshift-ci openshift-ci bot added the approved label Mar 4, 2024
@osmman osmman force-pushed the local-object-reference branch from ec54f0e to a0d2595 Compare March 4, 2024 11:00
@osmman osmman removed the request for review from lkatalin March 4, 2024 11:01
@bouskaJ
Copy link
Collaborator

bouskaJ commented Mar 4, 2024

@osmman Can you add description? Why v1.LocalObjectReference is not working anymore?

Copy link

openshift-ci bot commented Mar 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bouskaJ, osmman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 7f80a3d into main Mar 5, 2024
12 checks passed
@osmman osmman deleted the local-object-reference branch March 5, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants