retain and size set

[cooktheryan]

Set the pvc to be retained at default and specify size.

Follow up PR will include setting name but out of scope for initial issue. Also has been somewhat challenging so wanted to get this in and working first then begin the process to allow for name change

[osmman]

Follow up PR will include setting name but out of scope for initial issue. Also has been somewhat challenging so wanted to get this in and working first then begin the process to allow for name change

Will that PR include changes of PvcName? I am asking because currently it looks weird that we have option pvcName and pvc in same level of API.

[cooktheryan]

@osmman somewhat fighting through pvc naming right now. It's somewhat weird. Things appear to break if the variables of pvcName are used in their current way.

[cooktheryan]

If acceptable to @bouskaJ and @osmman I would like to generate a new issue on providing your own PVC name.

[osmman]

It looks like there is some bug when we setting default values. I sucessfully broke operator on nil pointer exception when I use this object:

apiVersion: rhtas.redhat.com/v1alpha1
kind: Trillian
metadata:
  name: example
  namespace: test
spec: {}

Error message:

panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x0 pc=0x103dce254]

goroutine 466 [running]:
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile.func1()
	/Users/tturek/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:116 +0x1a4
panic({0x104276580?, 0x10527ccb0?})
	/opt/homebrew/Cellar/go/1.21.5/libexec/src/runtime/panic.go:914 +0x218
github.com/securesign/operator/controllers/trillian/actions/logserver.deployAction.Handle(.....)
	/Users/tturek/Workspace/securesign/secure-sign-operator/controllers/trillian/actions/logserver/deployment.go:48 +0x1e4

[osmman]

default value is not work correctly. It will be set false for this example:

spec:
  database:
    create: true

final values will be

spec:
  database:
    create: true
    databaseSecretRef:
      name: rhtassk4q9
    pvc:
      name: trillian-mysql
      retain: false
      size: 5Gi

[cooktheryan]

@osmman I think this was a fallout of moving those items to common. This should be fixed now

[cooktheryan]

@osmman we should be good with the config above

deploy

apiVersion: rhtas.redhat.com/v1alpha1
kind: Securesign
metadata:
  labels:
    app.kubernetes.io/name: securesign-sample
    app.kubernetes.io/instance: securesign-sample
    app.kubernetes.io/part-of: trusted-artifact-signer
  name: securesign-sample
spec:
  rekor:
    externalAccess:
      enabled: true
    monitoring:
      enabled: false
  trillian:
    database:
      create: true

Verification

kubectl get rekor -o yaml
apiVersion: v1
items:
- apiVersion: rhtas.redhat.com/v1alpha1
  kind: Rekor
  metadata:
    creationTimestamp: "2024-02-20T16:56:20Z"
    generation: 3
    labels:
      app.kubernetes.io/component: rekor
      app.kubernetes.io/instance: securesign-sample
      app.kubernetes.io/managed-by: controller-manager
      app.kubernetes.io/name: securesign-sample
      app.kubernetes.io/part-of: trusted-artifact-signer
    name: securesign-sample
    namespace: default
    ownerReferences:
    - apiVersion: rhtas.redhat.com/v1alpha1
      blockOwnerDeletion: true
      controller: true
      kind: Securesign
      name: securesign-sample
      uid: 7195c262-0ba1-414a-b249-d7a6e1cb7f9c
    resourceVersion: "701"
    uid: 9f10e93f-031c-4a69-9c3e-84d4bfb38545
  spec:
    backFillRedis:
      enabled: true
      schedule: 0 0 * * *
    externalAccess:
      enabled: true
    monitoring: {}
    pvc:
      name: rekor-securesign-sample-pvc
      retain: true
      size: 5Gi

[cooktheryan]

I'll look to see if the trillian bug is still there

[osmman]

I'll look to see if the trillian bug is still there

You can cherry pick 3b7fee8f2de03b7a11ae67fd837e6cba9e75690a commit it should fix it.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cooktheryan, osmman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [cooktheryan,osmman]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[osmman]

/lgtm