-
-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow excluding analyzers globally #1180
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this contribution! I left a few comments which it would be great if you could address them. Thanks again!
I would also recommend to rebase this since there are some updates in the main. Thanks |
Thanks for quick feedback. |
Please go ahead. It's fine they don't need to be identical. These are anyhow small things. Thanks for addressing my comments! |
Is this fixing #1175 issue? |
Yes, but partly. |
* This change does not exclude analyzers for inline comment * Changed the expected issues count for G103, G109 samples for test. Previously G115 has been included in the issue count * Show analyzers IDs(G115, G602) in gosec usage help * See securego#1175
Addressed the Comments. Please Re-review. Thank you. |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1180 +/- ##
==========================================
- Coverage 67.53% 67.15% -0.38%
==========================================
Files 72 74 +2
Lines 3933 3992 +59
==========================================
+ Hits 2656 2681 +25
- Misses 1160 1189 +29
- Partials 117 122 +5 ☔ View full report in Codecov by Sentry. |
fixes #1175