Move colorama to install_requires in setup.py #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`colorama` was added to colorize output generated by some functions in `securesystemslib.interface`. Prior to this commit `colorama` was listed as extra requirement in setup.py under `extras_require["crypto"]` alongside `cryptography`. However, `securesystemslib.interface` does not properly handle an installation without `colorama`, as e.g. `secureystemslib.keys` does for an installation without `cryptography` (or `pynacl`), thus it cannot be an extra requirement.
|
Thanks, Lukas! This is something that always bothered me. Would it be worthwhile to later add support for non-colorama versions? (i.e., why pull output colorized on terminals that don't support it?) |
|
Yes absolutely, @SantiagoTorres! I think it would be useful to generally revise the code, related to optional dependencies (i.e. cyrptography, pynacl). IIRC, there is some unnecessary redundancy on one hand and then missing case handling on the other. I'll follow up with a separate issue. But I think this is a reasonable quick fix to close #153. |
|
Oh certainly, agreed. I think it'd be a possible first issue for new contributors. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #:
closes #153
Description of the changes being introduced by the pull request:
coloramawas added to colorize output generated by some functions insecuresystemslib.interface.Prior to this PR
coloramawas listed as extra requirement in setup.py underextras_require["crypto"]alongsidecryptography.However,
securesystemslib.interfacedoes not properly handle an installation withoutcolorama, as e.g.secureystemslib.keysdoes for an installation withoutcryptography(orpynacl), thus it cannot be an extra requirement.Moreover,
coloramadoes not require C extensions, which would be a good reason to keep it out of the standard installation.Please verify and check that the pull request fulfills the following
requirements: