This repository has been archived by the owner on Feb 16, 2023. It is now read-only.
Remove secret at old path when secret path is updated #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when updating the path of a secrethub_secret resource the secret would be created in the new location, but the secret would also remain at the old location. This commit changes the behavior so that the secret is removed in the old location when the path of the secret resource is changed.
florisvdg
approved these changes
Jan 25, 2021
There was a problem hiding this comment.
Yep, we can indeed now do this, unlike before, because the provider path_prefix has been removed.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when updating the
pathof asecrethub_secret resourcethe secret would be created in the new location, but the secret would also remain at the old location. This commit changes the behavior so that the secret is removed in the old location when the path of the secret resource is changed.