Add script to generate Windows installers (.msi) #58
Conversation
| @@ -26,3 +26,6 @@ build: | |||
|
|
|||
| install: | |||
| go install ${BUILD_FLAGS} ./cmd/secrethub | |||
|
|
|||
| msi: | |||
There was a problem hiding this comment.
Consider adding the make msi command to the goreleaser config as a pre or post build hook (not sure which would be preferred here, I think post). Then we can include the resulting .msi files in the release.
There was a problem hiding this comment.
I tried that at first, but those hooks very limited. Can have another look later.
| EXE=bin/secrethub.exe | ||
| VERSION=$(git describe --tags $(git rev-list --tags --max-count=1)) | ||
| MANUFACTURER=SecretHub | ||
| UPGRADE_CODE=7178CB18-B431-4A9D-B29E-D31E63A1CF77 |
There was a problem hiding this comment.
Yes this is an arbitrary GUID to identify our app, so Windows knows it's same app across potential name changes.
There was a problem hiding this comment.
Ah ok, got it 👍 Consider adding a comment as this is some weird arcane MSI knowledge.
|
It works, but it's not that pretty. It puts an icon on the desktop and it doesn't symlink the binary. |
|
Hmm, ok. Let's research how we can improve the installer. I think there are quite some options for setting e.g. the |
|
This is coming very soon separately from this PR. |
|
An MSI installer for Direct download links: |
No description provided.