Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

continue to fix Benchmark CI issue #968 #979

Merged
merged 3 commits into from
Feb 17, 2025
Merged

continue to fix Benchmark CI issue #968 #979

merged 3 commits into from
Feb 17, 2025

Conversation

w-gc
Copy link
Collaborator

@w-gc w-gc commented Jan 21, 2025

Pull Request

What problem does this PR solve?

Issue Number: Fixed #968

Possible side effects?

  • Performance:

  • Backward compatibility:

@w-gc w-gc changed the title continue to fix Asan/Benchmark CI issue #968 WIP: continue to fix Asan/Benchmark CI issue #968 Jan 21, 2025
@w-gc w-gc changed the title WIP: continue to fix Asan/Benchmark CI issue #968 continue to fix Asan/Benchmark CI issue #968 Feb 17, 2025
@w-gc w-gc changed the title continue to fix Asan/Benchmark CI issue #968 continue to fix Benchmark CI issue #968 Feb 17, 2025
Copy link
Member

@warriorpaw warriorpaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@tongke6 tongke6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tongke6 tongke6 merged commit 57b6cf8 into main Feb 17, 2025
9 checks passed
@tongke6 tongke6 deleted the wgc/fix branch February 17, 2025 12:16
@github-actions github-actions bot locked and limited conversation to collaborators Feb 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Asan/Benchmark CIs are broken
3 participants