Fix 502 errors #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdbhiggins
force-pushed
the
fix-502-errors
branch
from
96d6a93
to
9141dbb
Compare
kdbhiggins
force-pushed
the
fix-502-errors
branch
from
9141dbb
to
8f2d01a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gateway 502 errors have been causing a lot of incidents, particularly with the brand-transactions data-plane. This is issue has been reported on the main fork lyft#166, seems to manifest with concurrent requests.
I think it's caused by initialising the
MVELRuleFactoryonce, but then loading the rules into it per request (potentially across different threads). I'm changing the code here to load the rules config once, not per request. This means that you'll have to restart the server to change the rules, but IMO that is the expected behaviour for config files, not hot reloading.