Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chown the history file #4656

Merged
merged 2 commits into from
Feb 5, 2025
Merged

Chown the history file #4656

merged 2 commits into from
Feb 5, 2025

Conversation

gpotter2
Copy link
Member

@gpotter2 gpotter2 commented Feb 5, 2025

  • small fix so that sudo scapy on the first try doesn't kill the history file.

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.65%. Comparing base (d2c6055) to head (28a5bd2).

Files with missing lines Patch % Lines
scapy/main.py 71.42% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4656      +/-   ##
==========================================
+ Coverage   81.44%   81.65%   +0.21%     
==========================================
  Files         359      359              
  Lines       86428    86432       +4     
==========================================
+ Hits        70388    70573     +185     
+ Misses      16040    15859     -181     
Files with missing lines Coverage Δ
scapy/main.py 70.23% <71.42%> (+0.23%) ⬆️

... and 23 files with indirect coverage changes

@guedou guedou self-requested a review February 5, 2025 10:47
guedou
guedou previously approved these changes Feb 5, 2025
@gpotter2 gpotter2 merged commit 2f3f5dd into secdev:master Feb 5, 2025
22 of 23 checks passed
@gpotter2 gpotter2 deleted the main-histfile branch February 5, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants