Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the instance of ADDR_ENTRY[0] #4565

Merged
merged 2 commits into from
Dec 28, 2024
Merged

Conversation

guedou
Copy link
Member

@guedou guedou commented Oct 14, 2024

This PR fixed an issue reported by OSS-Fuzz.

I reduced the original reproducer to minimize the bytes added to the test cases.

@guedou guedou force-pushed the guedou/20241014/oss-fuzz_netbios branch from 4e0214a to 865c598 Compare October 14, 2024 18:19
@gpotter2
Copy link
Member

Test is failing

@guedou
Copy link
Member Author

guedou commented Oct 14, 2024 via email

@guedou guedou force-pushed the guedou/20241014/oss-fuzz_netbios branch from 865c598 to 48a3f2f Compare October 19, 2024 11:33
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.68%. Comparing base (6f0faf3) to head (d7b4c7a).
Report is 28 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4565      +/-   ##
==========================================
- Coverage   81.61%   80.68%   -0.94%     
==========================================
  Files         356      356              
  Lines       85545    85574      +29     
==========================================
- Hits        69819    69045     -774     
- Misses      15726    16529     +803     
Files with missing lines Coverage Δ
scapy/layers/netbios.py 92.75% <100.00%> (ø)

... and 27 files with indirect coverage changes

@gpotter2 gpotter2 merged commit 706568b into master Dec 28, 2024
22 of 23 checks passed
@gpotter2 gpotter2 deleted the guedou/20241014/oss-fuzz_netbios branch December 28, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants