Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: skip OpenLDAP tests on Packit #4540

Merged
merged 1 commit into from
Sep 28, 2024
Merged

Conversation

evverx
Copy link
Contributor

@evverx evverx commented Sep 28, 2024

until I figure out whether it's possible to set up slapd there by analogy with what the scapy action on GitHub does.

It's a follow-up to #4539.

until I figure out whether it's possible to set up slapd there by
analogy with what the scapy action on GitHub does.

It's a follow-up to secdev#4539.
@evverx
Copy link
Contributor Author

evverx commented Sep 28, 2024

Looks like the OpenLDAP tests failed: https://github.com/secdev/scapy/actions/runs/11085252379/job/30801458305?pr=4540. It's not related to this PR though.

###(001)=[failed] (OpenLDAP) connect to server, bind, search

>>> cli = LDAP_Client()
>>> cli.connect("127.0.0.1")
┃ Connecting to 127.0.0.1 on port 389...
└ Connected from ('127.0.0.1', 53032)
>>> cli.bind(LDAP_BIND_MECHS.SIMPLE, simple_username="cn=admin,dc=scapy,dc=net", simple_password="Bonjour1")
>> LDAP_BindRequest
<< LDAP_BindResponse
SIMPLE bind succeeded !
>>> res = cli.search("dc=scapy,dc=net", "(&(givenName=Another)(sn=Test))", scope=2)
>> LDAP_SearchRequest
<< LDAP_SearchResponseEntry
###[ LDAP ]###
  messageID = 0x2 <ASN1_INTEGER[2]>
  \protocolOp\
   |###[ LDAP_SearchResponseEntry ]###
   |  objectName= <ASN1_STRING[b'uid=another,ou=People,dc=scapy,dc=net']>
   |  \attributes\
   |   |###[ LDAP_SearchResponseEntryAttribute ]###
   |   |  type      = <ASN1_STRING[b'objectClass']>
   |   |  \values    \
   |   |   |###[ LDAP_SearchResponseEntryAttributeValue ]###
   |   |   |  value     = <ASN1_STRING[b'top']>
   |   |   |###[ LDAP_SearchResponseEntryAttributeValue ]###
   |   |   |  value     = <ASN1_STRING[b'person']>
   |   |   |###[ LDAP_SearchResponseEntryAttributeValue ]###
   |   |   |  value     = <ASN1_STRING[b'inetOrgPerson']>
   |   |###[ LDAP_SearchResponseEntryAttribute ]###
   |   |  type      = <ASN1_STRING[b'cn']>
   |   |  \values    \
   |   |   |###[ LDAP_SearchResponseEntryAttributeValue ]###
   |   |   |  value     = <ASN1_STRING[b'Another Test']>
   |   |###[ LDAP_SearchResponseEntryAttribute ]###
   |   |  type      = <ASN1_STRING[b'uid']>
   |   |  \values    \
   |   |   |###[ LDAP_SearchResponseEntryAttributeValue ]###
   |   |   |  value     = <ASN1_STRING[b'another']>
   |   |###[ LDAP_SearchResponseEntryAttribute ]###
   |   |  type      = <ASN1_STRING[b'sn']>
   |   |  \values    \
   |   |   |###[ LDAP_SearchResponseEntryAttributeValue ]###
   |   |   |  value     = <ASN1_STRING[b'Test']>
   |   |###[ LDAP_SearchResponseEntryAttribute ]###
   |   |  type      = <ASN1_STRING[b'givenName']>
   |   |  \values    \
   |   |   |###[ LDAP_SearchResponseEntryAttributeValue ]###
   |   |   |  value     = <ASN1_STRING[b'Another']>
   |   |###[ LDAP_SearchResponseEntryAttribute ]###
   |   |  type      = <ASN1_STRING[b'userPassword']>
   |   |  \values    \
   |   |   |###[ LDAP_SearchResponseEntryAttributeValue ]###
   |   |   |  value     = <ASN1_STRING[b'testing']>
  Controls  = None

Traceback (most recent call last):
  File "<input>", line 2, in <module>
  File "/home/runner/work/scapy/scapy/scapy/layers/ldap.py", line 2085, in search
    raise TimeoutError("Search timed out.")
TimeoutError: Search timed out.

Copy link

codecov bot commented Sep 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.51%. Comparing base (f7a6411) to head (2ae96a6).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4540      +/-   ##
==========================================
- Coverage   81.62%   81.51%   -0.11%     
==========================================
  Files         356      356              
  Lines       85533    85533              
==========================================
- Hits        69814    69723      -91     
- Misses      15719    15810      +91     

see 11 files with indirect coverage changes

@gpotter2
Copy link
Member

Looks like the OpenLDAP tests failed

Thanks for reporting that.
I can't figure out how to replicate this >:( I tried to loop that test on all possible Python / PyPy versions to no avail. Must be a stupid race or something. I'll try to debug it through github.

In the mean time, thanks for the PR !

@gpotter2 gpotter2 merged commit 41b6f2c into secdev:master Sep 28, 2024
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants