The Windows Update #4214
Merged
The Windows Update #4214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4214 +/- ##
==========================================
+ Coverage 81.77% 81.97% +0.20%
==========================================
Files 331 345 +14
Lines 76716 81410 +4694
==========================================
+ Hits 62731 66734 +4003
- Misses 13985 14676 +691
|
gpotter2
force-pushed
the
the-windows-update
branch
18 times, most recently
from
ba83083 to
341a787
Compare
gpotter2
force-pushed
the
the-windows-update
branch
7 times, most recently
from
0395fe4 to
f9c2603
Compare
gpotter2
force-pushed
the
the-windows-update
branch
3 times, most recently
from
d22aafa to
bd5761f
Compare
gpotter2
force-pushed
the
the-windows-update
branch
from
d400f1f to
b716ceb
Compare
gpotter2
force-pushed
the
the-windows-update
branch
from
792583c to
8a50c24
Compare
This PR includes a major refactor regarding several Windows specific
protocols, particularily SMB2/3 and DCE/RPC. It also touches many parts
of Scapy's core in order to accommodate those changes.
This includes:
- DCE/RPC:
- DCERPC_Client with support for NCACN_IP_TCP and NCACN_NP
- DCERPC_Server with support for NCACN_IP_TCP and NCACN_NP
- Finish NDR engine !
- Server/Client Endpoint mapper support
- Premises of a few special clients (Netlogon, DCOM, ...)
- A few RPC interfaces (to debug/test the DCE/RPC engine. TODO:
MORE !)
- Documentation !
- SMB2/3:
- Protocol refactor, many more SMB2/3 structures supported
- Server (class + 'simple' util smbserver()) (2.0.2 to 3.1.1)
- Client (class + interactive CLI smbclient()) (2.0.2 only)
- SMB socket, RPC over SMB socket, etc.
- Documentation !
- Kerberos:
- KerberosSSP to use in SMB/RPC clients/servers
- Crypto: use cryptography, latest RFC8009, typing, etc.
- Util functions krb_as_req, krb_tgt_req, kpasswd (both modes), etc.
- [MS-KILE] variants, SFU and more !
- Both MIT and Windows variations support
- NTLM:
- refactor, clean SSP
- remove relay (TODO: reimplement with the new system)
- Extensive GSSAPI / SPNEGO support !
- Ticketer++
- CCache support: read/write
- Kerberos integration: ask/renew/resign/edit tickets
- Change ticket fields through a GUI ! and more !
- LDAP
- Fixes, ASN.1 Windows variation support
- dclocator, answering machine for "LDAP PING"
- Automaton:
- fixes (memory usage on Windows)
- support for EOF events
- spawn() mode, better socket.socket support and more !
- StreamSocket changes, support for TCP reassembly, etc !
- Unit tests for everything (using samba, etc.)
gpotter2
force-pushed
the
the-windows-update
branch
from
8a50c24 to
f25f95f
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
I reviewed a few files that I have an idea about, and everything looks good so far |
gpotter2
force-pushed
the
the-windows-update
branch
from
e52af78 to
a5d3192
Compare
evverx
reviewed
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a major refactor regarding several Windows specific protocols, particularily SMB2/3 and DCE/RPC. It also touches many parts of Scapy's core in order to accommodate those changes.
This includes:
How to review:
smbclientandsmbserveragainst Windows machinesfixes #4170