Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support coverage 5.0+ #2379

Merged
merged 1 commit into from
Dec 18, 2019
Merged

Support coverage 5.0+ #2379

merged 1 commit into from
Dec 18, 2019

Conversation

gpotter2
Copy link
Member

This is either a bug with coverage.py (nedbat/coveragepy#880) or simply a breaking change.

@gpotter2 gpotter2 added the tests label Dec 15, 2019
@codecov
Copy link

codecov bot commented Dec 15, 2019

Codecov Report

Merging #2379 into master will decrease coverage by 0.1%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2379      +/-   ##
==========================================
- Coverage   87.82%   87.72%   -0.11%     
==========================================
  Files         243      241       -2     
  Lines       50778    50458     -320     
==========================================
- Hits        44598    44264     -334     
- Misses       6180     6194      +14
Impacted Files Coverage Δ
scapy/compat.py 70.51% <0%> (-7.7%) ⬇️
scapy/autorun.py 78.51% <0%> (-4.14%) ⬇️
scapy/ansmachine.py 84% <0%> (-1%) ⬇️
scapy/layers/inet6.py 81.8% <0%> (-0.22%) ⬇️
scapy/libs/winpcapy.py
scapy/libs/ethertypes.py
scapy/layers/ntp.py 91.77% <0%> (+0.26%) ⬆️

guedou
guedou previously approved these changes Dec 16, 2019
Copy link
Member

@guedou guedou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks ok. Let's wait for an update from coverage before merging.

@gpotter2
Copy link
Member Author

gpotter2 commented Dec 17, 2019

Fixed in nedbat/coveragepy@842f585
It was a bug, but also our fault for using it wrong: we shouldn't actually use --append (-a) since we have enabled the multiprocessing mode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants